fix: Check language service is not already disabled #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
suggested changes
Oct 18, 2019
kyliau
force-pushed
the
disable-angular
branch
from
ca44388 to
e9404e9
Compare
ayazhafiz
approved these changes
Oct 18, 2019
andrius-pra
approved these changes
Oct 18, 2019
When making the check to determine if a project is Angular, it could be the case that the language service is already disabled. This happens when there are files in the project that exceeded limit. This PR fixes the issue by first checking if the language service is already disabled. Also added much more information to the logs to help users diagnose the problem. Messages are logged to both remote console (vscode) and file so that the former could inform users in their editor, and the latter makes it much easier to correlate the sequence of events in both TypeScript and Angular. Related: angular#416
kyliau
force-pushed
the
disable-angular
branch
from
527b9c3 to
276fe4d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making the check to determine if a project is Angular, it could be
the case that the language service is already disabled. This happens
when there are files in the project that exceeded limit.
This PR fixes the issue by first checking if the language service is
already disabled. Also added much more information to the logs to help
users diagnose the problem. Messages are logged to both remote console
(vscode) and file so that the former could inform users in their editor,
and the latter makes it much easier to correlate the sequence of events
in both TypeScript and Angular.
Related: #416