Skip to content

fix: Do not disable language service #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Oct 17, 2019

This PR reverts the change to disable the language service if
@angular/core is not detected in a project while
#416 is being investigated.

@kyliau kyliau requested a review from ayazhafiz October 17, 2019 18:22
Copy link
Contributor

@ayazhafiz ayazhafiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #416? If not, I think it would be helpful to determine the root cause there before committing such a change.

This PR reverts the change to disable the language service if
@angular/core is not detected in a project while
angular#416 is
being investigated.
@kyliau kyliau changed the title fix: Do not disable langauge service fix: Do not disable language service Oct 17, 2019
@kyliau kyliau closed this Oct 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants