Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

docs: timeouts: ignoreSynchronization example should be asynchronous #3330

Closed
wants to merge 1 commit into from
Closed

Conversation

laurence-myers
Copy link

ignoreSynchronization is synchronous, whereas other flow commands are asynchronous (promise-based). Therefore, to use ignoreSynchronization correctly, you need to chain promises using the control flow.

As per this issue/comment:
#2275 (comment)

ignoreSynchronization is synchronous, whereas other flow commands are asynchronous (promise-based). Therefore, to use ignoreSynchronization correctly, you need to chain promises.

As per this issue/comment:
#2275 (comment)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@laurence-myers
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jul 5, 2016
@juliemr
Copy link
Member

juliemr commented Jul 6, 2016

This isn't actually how ignoreSynchronization works, the original docs are correct. Protractor checks for ignoreSynchronization when tasks are scheduled, not when they are executed. (See the code here)

I agree that this is confusing, and we'd like to fix up the API when we start using BlockingProxy. See #1939

@juliemr juliemr closed this Jul 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants