Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Replace browser.rootEl with browser.setAngularRoot() #3947

Closed
heathkit opened this issue Jan 9, 2017 · 2 comments
Closed

Replace browser.rootEl with browser.setAngularRoot() #3947

heathkit opened this issue Jan 9, 2017 · 2 comments

Comments

@heathkit
Copy link
Contributor

heathkit commented Jan 9, 2017

Similar to replacing browser.ignoreSynchronization with browser.waitForAngularEnabled(), we should change setting the root element from a property to a method call.

@heathkit heathkit self-assigned this Jan 9, 2017
@heathkit
Copy link
Contributor Author

heathkit commented Jan 9, 2017

Also, make sure we do the right thing in this case:

browser.setAngularRoot('x');
browser.get('http://something.com').then(() => {
   element(by.css('button')).click();
});
browser.setAngularRoot('y');
element(by.css('other_button')).click();

@sjelin
Copy link
Contributor

sjelin commented Jan 9, 2017

Same with useAllAngularTestabilities

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants