feat(autocomplete): add the ability to highlight the first option on open #9495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
8423/autocomplete-highlight-first-option
branch
3 times, most recently
from
abc0535 to
e2ff050
Compare
jelbourn
reviewed
Jan 24, 2018
src/lib/autocomplete/autocomplete.ts
Outdated
| * Can be configured globally through the `MAT_AUTOCOMPLETE_DEFAULT_OPTIONS` token. | ||
| */ | ||
| @Input() | ||
| get highlightFirstOption(): boolean { return this._highlightFirstOption; } |
There was a problem hiding this comment.
Chatted w/ Miles and Joey, we came to autoActiveOption as the proposal for this. I like using "active" since it aligns with the term we use in list-key-manager and in datepicker. Thoughts?
…open Adds the ability for the consumer opt-in to having the autocomplete highlight the first option when opened. Includes an injection token that allows it to be configured globally. Fixes angular#8423.
crisbeto
force-pushed
the
8423/autocomplete-highlight-first-option
branch
from
e2ff050 to
e758986
Compare
|
Good to go @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
finally this feature can replace select2 search functionality thanks |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the consumer opt-in to having the autocomplete highlight the first option when opened. Includes an injection token that allows it to be configured globally.
Fixes #8423.