Skip to content

Conversation

julianobrasil
Copy link
Contributor

@julianobrasil julianobrasil commented Jan 13, 2018

Does it need any tests?

Also there's a little side effect: if the thumb label is already visible and you try to show it programmatically by, let's say, clicking on a button, as the focus will be lost to the clicked button, the thumb label will disappear and appear again. Just realized that this is kind of normal (but I think it'd be better without this blinking)

image

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 13, 2018
@mmalerba
Copy link
Contributor

The blinking is because you're blurring the slider when you click on the button and then programmatically re-focusing it. One thing that could potentially be done is to add a slight delay after blurring before hiding the thumb (let's not do it in this PR though)

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 16, 2018
@jelbourn
Copy link
Member

@julianobrasil DM me your email address on Twitter?

@jelbourn jelbourn merged commit 2d592a5 into angular:master Jan 23, 2018
@julianobrasil
Copy link
Contributor Author

@jelbourn, I wasn't able to DM you (twitter policies), but my email address is public in github: https://github.com/julianobrasil

@julianobrasil julianobrasil deleted the thumbLabel2 branch January 26, 2018 00:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat (Mat-Slider) : Focus method and blur Output
4 participants