fix(button): ensure icons are aligned vertically. #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The icon buttons are never a perfect cirlce, because they can shrink (depending on siblings). In Material 1 we solved this by adding `min-width/height`, but having flex-shrink is more approriated here (it allows developers to easily overwrite height / width) * Sets the line-height for icons only to `i` and `md-icon` elements (as same as for fab buttons) Fixes angular#1093.
googlebot
added
the
cla: yes
|
R: @tinayuangao |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon buttons are never a perfect cirlce, because they can shrink (depending on siblings).
In Material 1 we solved this by adding
min-width/height, but having flex-shrink is more elegant here (it allows developers to easily overwrite height and width)Sets the line-height for icons only to
iandmd-iconelements (as same as for fab buttons)Fixes #1093.