Skip to content

fix(progress-spinner): Create internal default to force animations to always be on #11462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2018
Merged

fix(progress-spinner): Create internal default to force animations to always be on #11462

merged 1 commit into from
Jun 21, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels May 22, 2018
@josephperrott josephperrott requested a review from jelbourn as a code owner May 22, 2018 20:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 22, 2018
@ngbot
Copy link

ngbot bot commented May 22, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott added the blocked This issue is blocked by some external factor, such as a prerequisite PR label May 22, 2018
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label May 22, 2018
@ngbot
Copy link

ngbot bot commented Jun 7, 2018

Hi @josephperrott! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Jun 7, 2018

Hi @josephperrott! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@josephperrott josephperrott force-pushed the noop-animation-server branch from 6d1098c to 9567156 Compare June 18, 2018 19:47
@josephperrott josephperrott removed blocked This issue is blocked by some external factor, such as a prerequisite PR pr: lgtm labels Jun 18, 2018
@josephperrott josephperrott requested a review from vikerman June 18, 2018 19:48
@josephperrott josephperrott force-pushed the noop-animation-server branch from 9567156 to 707f497 Compare June 18, 2018 21:38
@josephperrott josephperrott changed the title fix(progress-spinner, progress-bar): Do not prevent animations while SSR fix(progress-spinner): Create internal default to force animations to always be on Jun 18, 2018
@josephperrott josephperrott force-pushed the noop-animation-server branch from 707f497 to 9e79630 Compare June 18, 2018 21:45
@josephperrott josephperrott force-pushed the noop-animation-server branch from 9e79630 to d2554ca Compare June 19, 2018 16:08
jelbourn
jelbourn approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 19, 2018
@tinayuangao tinayuangao merged commit d96adbe into angular:master Jun 21, 2018
@josephperrott josephperrott deleted the noop-animation-server branch June 21, 2018 14:28
tinayuangao pushed a commit that referenced this pull request Jun 25, 2018
@josephperrott @tinayuangao
fix(progress-spinner): create internal default to force animations to…
11f3993 
… always be on (#11462)
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@josephperrott @victoriaaa234
fix(progress-spinner): create internal default to force animations to…
d484783 
… always be on (#11462)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@vikerman vikerman Awaiting requested review from vikerman

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @jelbourn @mmalerba @googlebot @tinayuangao