feat(overlay): add support for automatically setting the transform-origin based on the current position #10868
Conversation
crisbeto
requested review from
andrewseguin,
jelbourn,
kara and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
flexible-position-transform-origin
branch
from
770b747 to
3a71f1a
Compare
| * @param selector CSS selector that will be used to find the target | ||
| * elements onto which to set the transform origin. | ||
| */ | ||
| withTransformOriginOn(selector: string): this { |
There was a problem hiding this comment.
Add documentation for this in overlay.md?
crisbeto
force-pushed
the
flexible-position-transform-origin
branch
from
3a71f1a to
bffeaff
Compare
|
Sorry for the delay @jelbourn, it seems like I missed the notification. I've rebased the branch and have addressed the feedback. |
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
…igin based on the current position Currently we have a handful of components where we set the `transform-origin` depending on the position of their overlay. This ends up being a fair bit of similar logic that is scattered across the different components. These changes consolidate that logic into an option on the `FlexibleConnectedPositionStrategy`.
crisbeto
force-pushed
the
flexible-position-transform-origin
branch
from
bffeaff to
4883a56
Compare
| * @param delay Amount of milliseconds to the delay showing the tooltip. | ||
| */ | ||
| show(position: TooltipPosition, delay: number): void { | ||
| show(delay: number): void { |
There was a problem hiding this comment.
This is a breaking API change; causing some issues trying to sync
There was a problem hiding this comment.
I can see how it could break somebody, but this is on a private component that is only exposed through an underscored property.
There was a problem hiding this comment.
It's from a team that's extending the tooltip. I guess I can update them.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Currently we have a handful of components where we set the
transform-origindepending on the position of their overlay. This ends up being a fair bit of similar logic that is scattered across the different components. These changes consolidate that logic into an option on theFlexibleConnectedPositionStrategy.