This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): don't bind scroll event if scrolling is disabled #9947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the panel would bind to a scroll event and determine within the handler whether to do anything. This change moves the check outside of the event handler and only binds if scrolling is enabled.
crisbeto
added
needs: review
crisbeto
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the panel would bind to a scroll event and determine within the handler whether to do anything. This change moves the check outside of the event handler and only binds if scrolling is enabled.