This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(util): check for definition of window.performance.now before using in mdUtil #9664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in mdUtil The previous behavior assumes the existence of the now() function in browsers that provide the window.performance API. This change verifies it is available and if not, uses existing fallbacks.
crisbeto
approved these changes
Sep 22, 2016
There was a problem hiding this comment.
LGTM @ThomasBurleson. We actually recently dealt with something similar in #9254.
ThomasBurleson
added
needs: presubmit
and removed
needs: review
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
…g in mdUtil (angular#9664) The previous behavior assumes the existence of the now() function in browsers that provide the window.performance API. This change verifies it is available and if not, uses existing fallbacks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior assumes the existence of the now() function in browsers that provide the
window.performance API. This change verifies it is available and if not, uses existing fallbacks.
According to the Mozilla Developer Network reference page, the following browsers have the
window.performanceAPI, but not support fornow():