Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(panel): configurable animation duration #9570

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

crisbeto
Copy link
Member

  • Adds the ability to specify the duration of an animation the panel.
  • Fixes the MdPanelAnimation not showing up in the docs.

Fixes #9177.

@crisbeto crisbeto added needs: team discussion This issue requires a decision from the team before moving forward. needs: review This PR is waiting on review from the team labels Sep 10, 2016
@crisbeto
Copy link
Member Author

crisbeto commented Sep 10, 2016

@ErinCoughlan @bradrich this currently works on the panel itself, but do you think we should also make it configurable for the backdrop?

@crisbeto crisbeto added this to the 1.1.2 milestone Sep 10, 2016
@bradrich
Copy link
Contributor

I would say yes. The backdrop is in itself a panel as well. I haven't had the chance to look through the code.

@crisbeto
Copy link
Member Author

crisbeto commented Sep 10, 2016

My worry about it is that the backdrop animation config would have to be passed through the panel, not the newPanelAnimation. This could make the API confusing. Otherwise we can also take the duration from the panel's animation object, but that would mean the backdrop always having the same duration as the panel.

@bradrich
Copy link
Contributor

Is there a case where someone would want the backdrop to have a different duration?

@crisbeto
Copy link
Member Author

The only case I can think of is if you wanted to prevent the user from clicking/scrolling around while a longer animation was running.

@bradrich
Copy link
Contributor

That is true. Maybe we should make the backdrop animation always show at a default 300ms. Then all duration variations could be only on the panel opening above the backdrop. How does that sound?

I am also really looking forward to seeing how you pulled off the animation duration change.

@crisbeto crisbeto removed the needs: team discussion This issue requires a decision from the team before moving forward. label Sep 12, 2016
@crisbeto
Copy link
Member Author

Removing the needs: discussion since we decided to match the backdrop duration with the panel's.

@ErinCoughlan
Copy link
Contributor

Nice work! LGTM.

* Adds the ability to specify the duration of an animation the panel.
* Fixes the `MdPanelAnimation` not showing up in the docs.

Fixes angular#9177.
@crisbeto
Copy link
Member Author

crisbeto commented Sep 12, 2016

Updated to have the backdrop inherit the panel's animation duration. Not a huge fan of having to save what the original duration value was, but I couldn't think of a better way of passing it to the backdrop (aside from specifying the units).

@crisbeto
Copy link
Member Author

@ThomasBurleson this should be good to go.

@ErinCoughlan
Copy link
Contributor

@ThomasBurleson I think this PR is good to go. Can we presubmit/merge it soon?

@ErinCoughlan ErinCoughlan added needs: presubmit and removed needs: review This PR is waiting on review from the team labels Sep 26, 2016
@hansl hansl merged commit bee04f3 into angular:master Sep 26, 2016
Frank3K pushed a commit to Frank3K/material that referenced this pull request Oct 8, 2016
* Adds the ability to specify the duration of an animation the panel.
* Fixes the `MdPanelAnimation` not showing up in the docs.

Fixes angular#9177.
crisbeto added a commit to crisbeto/material that referenced this pull request Oct 23, 2016
…anel

* Adds the ability to update the animation of a panel, without having to re-create it.
* Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in angular#9570.
crisbeto added a commit to crisbeto/material that referenced this pull request Oct 23, 2016
…anel

* Adds the ability to update the animation of a panel, without having to re-create it.
* Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in angular#9570.
kara pushed a commit that referenced this pull request Nov 17, 2016
…anel (#9895)

* Adds the ability to update the animation of a panel, without having to re-create it.
* Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in #9570.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants