-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(panel): configurable animation duration #9570
Conversation
@ErinCoughlan @bradrich this currently works on the panel itself, but do you think we should also make it configurable for the backdrop? |
I would say yes. The backdrop is in itself a panel as well. I haven't had the chance to look through the code. |
My worry about it is that the backdrop animation config would have to be passed through the panel, not the |
Is there a case where someone would want the backdrop to have a different duration? |
The only case I can think of is if you wanted to prevent the user from clicking/scrolling around while a longer animation was running. |
That is true. Maybe we should make the backdrop animation always show at a default 300ms. Then all duration variations could be only on the panel opening above the backdrop. How does that sound? I am also really looking forward to seeing how you pulled off the animation duration change. |
feeb76e
to
6fb7d0f
Compare
Removing the |
Nice work! LGTM. |
* Adds the ability to specify the duration of an animation the panel. * Fixes the `MdPanelAnimation` not showing up in the docs. Fixes angular#9177.
6fb7d0f
to
09e7e92
Compare
Updated to have the backdrop inherit the panel's animation duration. Not a huge fan of having to save what the original duration value was, but I couldn't think of a better way of passing it to the backdrop (aside from specifying the units). |
@ThomasBurleson this should be good to go. |
@ThomasBurleson I think this PR is good to go. Can we presubmit/merge it soon? |
* Adds the ability to specify the duration of an animation the panel. * Fixes the `MdPanelAnimation` not showing up in the docs. Fixes angular#9177.
…anel * Adds the ability to update the animation of a panel, without having to re-create it. * Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in angular#9570.
…anel * Adds the ability to update the animation of a panel, without having to re-create it. * Adds a unit test for verifying that the backdrop animation duration matches the one of the panel. This was missed in angular#9570.
MdPanelAnimation
not showing up in the docs.Fixes #9177.