This repository was archived by the owner on Sep 5, 2024. It is now read-only.
docs(mdPanel): fix formatting #9562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ErinCoughlan
added
type: docs
pr: merge ready
|
Thanks. Rebased. |
|
@zbjornson Can you squash the two commits with the rebase? |
|
Done :) |
|
Urg wait -- the line endings got changed in my last push, sec... |
|
Let's keep this minimal to just fix the layout. A diff on every line needs to be considered more carefully. And it messes with blame for the entire file. |
* Use constant-width formatting for the position guides. * Fix invalid quotation mark (‘’ -> ''). * Fix escaped & problem (&) by changing syntax. * Remove unused variable.
|
OK, sorry about that -- back to the minimal diff. |
|
Perfect. Thanks for the quick responses. LGTM. |
ErinCoughlan
removed
the
needs: rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
70c146f:
(compare with https://material.angularjs.org/latest/api/type/MdPanelPosition#addPanelPosition)
f8c0b31:
use strict.toppingsvariable/parameter.&) by slightly changing syntax.Note: this file is checked in to github with CRLF line endings. I did not fix that.