This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): md-maxlength not properly updates on model changes. #8351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2016
|
LGTM @ThomasBurleson |
|
👍 |
ThomasBurleson
added
needs: rebase
|
@devversion - please rebase and test. Thx. |
devversion
force-pushed
the
fix/max-length-model-update
branch
from
198de5c to
2c27992
Compare
devversion
added
needs: review
* Currently the md-maxlength char counter was not updated properly and listening on the different events is unnecessary. ngModelController will already update the model, when the `input` event gets called. Additonally we can cover all updates in the $validator itself, because it will always update, when changes get applied to the model. Fixes angular#1870.
devversion
force-pushed
the
fix/max-length-model-update
branch
from
2c27992 to
f35cbc0
Compare
|
@ThomasBurleson Done. |
|
@topherfangio Ping for review :) |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
ThomasBurleson
added
needs: presubmit
and removed
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the md-maxlength char counter was not updated properly and listening on the different events is unnecessary.
ngModelController will also update the model, when the
inputevent gets called.Additonally we can cover all updates in the $validator itself, because it will always update, when changes get applied to the model.
Fixes #1870. Referencing #8351