This repository was archived by the owner on Sep 5, 2024. It is now read-only.
update(panel): refactor positioning to allow multiple. #8211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @name MdPanelPosition#withPanelXPosition | ||
| * @param {string} xPosition | ||
| * @name MdPanelPosition#withPanelPosition | ||
| * @param {string} xpos |
There was a problem hiding this comment.
nit: Can you keep these as xPosition and yPosition as it directs the user towards the constants with the same name? (We haven't used pos anywhere public.)
ErinCoughlan
force-pushed
the
feat/panel
branch
2 times, most recently
from
8f46bd2 to
b1c1bde
Compare
gmoothart
force-pushed
the
intelligent-positioning
branch
3 times, most recently
from
6273f1e to
eefcfbe
Compare
|
PTAL. Comments addressed and API simplified to just one method |
| @@ -1765,7 +1776,10 @@ MdPanelPosition.prototype._calculatePanelPosition = function(panelEl) { | |||
| var targetRight = targetBounds.right; | |||
| var targetWidth = targetBounds.width; | |||
|
|
|||
| switch (this._xPosition) { | |||
| // TODO(gmoothart): intelligently pick the first on-screen position. | |||
| var pos = this._positions[0] || {}; | |||
There was a problem hiding this comment.
Watch variable names pos -> position
|
Please add a test for multiple positions, verifying that they are added to an array. Then LGTM. |
gmoothart
force-pushed
the
intelligent-positioning
branch
from
eefcfbe to
9f4f19e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes needed for #7878
@ErinCoughlan @jelbourn @DerekLouie @KarenParker @ThomasBurleson