fix(interim, toast): add hide queue to prevent multiple interims at same time

[devversion]

After this patch, the interim stack will pick up the first added element from the stack which
is not in hide process. At the moment we always take the first added (not caring about current hide process).

Also the stack always removes the elements immediately, which causes errors when showing multiple interims (for example spamming toasts). After this fix, we will remove the elements after the hide-process is done (like a stack queue)

Fixes #6633 Fixes #8111 Fixes #4822

[devversion]

Not sure about the rejection, but that's the best way to prevent the interim element to stuck on showing. Any suggestions?

[EladBezalel]

return $q.reject('Too many interim elements in queue!');

[devversion]

Thanks, definitely better!

[GongT]

cant get your point
But var hideExisting = !options.skipHide && stack.length ? service.hide() : $q.when(true); will constantly True. you must misunderstand stack.

[devversion]

@GongT - I think you just didn't read the complete code. I will talk through the steps with you...
If we show an interim element, we check if have already an element in the stack, if so we close the previous element in stack, calling the hide method, their we will return the stack element (but not remove that instantly as before), so the stack will work as desired. In the current version we always removed the interim element instantly from the stack and returned the instance, that's why multiple interim elements will be removed in a wrong order.

In this PR, we only remove the element from the stack if the hide is completed.
If we destroy the interim element through the API, we remove the latest element in stack using our queue count, so the order will be always right!

[EladBezalel]

can you fix it to be just options.closeTo

also the else statement is redundant because we return value from the last if statement

[devversion]

Updated, but I don't get what you mean with the else statement?

if (options.closeAll) {
  return $q.all(stack.reverse().map(closeElement));
} else if (options.closeTo) {
  return $q.all(stack.slice(options.closeTo).map(closeElement));
} else {
  return closeElement(stack[hideQueue]);
}

Every check will be used. Mostly this return closeElement(stack[hideQueue]); when showing / hiding a toast

[EladBezalel]

what i meant is some thing like this:

if (options.closeAll) {
  return $q.all(stack.reverse().map(closeElement));
} 

if (options.closeTo) {
  return $q.all(stack.slice(options.closeTo).map(closeElement));
}

return closeElement(stack[hideQueue]);

[devversion]

Ahh got it 😄 Done!

[devversion]

@EladBezalel - Updated the description of the PR (also waiting for #7053 for being merged). Just made this PR compatible with the new changes from #7053.

After this patch, the interim stack will pick up the first added element from the stack which
is not in hide process. At the moment we always take the first added (not caring about current hide process).

Also the stack always removes the elements immediately, which causes errors when showing multiple interims (for example spamming toasts). After this fix, we will remove the elements after the hide-process is done (like a stack queue)

[devversion]

Closing this, because I will improve that, when we starting to support multiple dialogs.

That means, we need to take a more accurate look at the interim element stack.