This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(sidenav): Only restore focus if user interaction was keyboard #5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally the Sidenav restores every time the last active element, so the focus won't disappear from the triggered button after closing the sidenav Fixes angular#5563
|
I want to point to @marcysutton, what do you think? |
|
@devversion - what do you mean point-to ? @marcysutton can you review this PR ? |
|
I am currently traveling but I will review it when I get a chance. |
|
@ThomasBurleson Yeah I mean she should review my PR. And I have a little question to you, what means the new label?, can u even take a look at the code? @marcysutton, @ThomasBurleson: I will try to improve / refactor that code Perhaps I should provide a global service for the last interaction type?. Now the listener get registered foreach |
devversion
added a commit
to devversion/material
that referenced
this pull request
Nov 6, 2015
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 References angular#5583
|
I created a second PR to fix that issue. This time its a feature which can be used in other components too (my favorite one). It got already tested manually. |
|
@devversion as #5589 is the active PR can i close this one? |
|
@EladBezalel Yes, I prefer the #5589 PR, but keep this PR open, I'm still waiting for a decision, which variant we will take |
devversion
added a commit
to devversion/material
that referenced
this pull request
Nov 9, 2015
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 References angular#5583 feat(interaction): add test for interaction which fakes a keyboard input and validates it test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2 style(interaction): fix styling of the previous commits
devversion
added a commit
to devversion/material
that referenced
this pull request
Nov 9, 2015
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589 feat(interaction): add test for interaction which fakes a keyboard input and validates it test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2 style(interaction): fix styling of the previous commits
|
I think that's definitely the wrong way of implementation, so I will close this for cleanup purposes |
devversion
added a commit
to devversion/material
that referenced
this pull request
Nov 11, 2015
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589 feat(interaction): add test for interaction which fakes a keyboard input and validates it test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2 style(interaction): fix styling of the previous commits test(sidenav): add sidenav focus restore test triggered by keyboard test(sidenav): add focus restore test for mouse and patch other one fix(sidenav): test
devversion
added a commit
to devversion/material
that referenced
this pull request
Nov 12, 2015
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589 feat(interaction): add test for interaction which fakes a keyboard input and validates it test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2 style(interaction): fix styling of the previous commits test(sidenav): add sidenav focus restore test triggered by keyboard test(sidenav): add focus restore test for mouse and patch other one fix(sidenav): test fix(sidenav): replace deprecated methods, and remove aria label test(sidenav): revert deprecated methods.
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 24, 2016
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions. The service got created to use that feature for other components too Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589 feat(interaction): add test for interaction which fakes a keyboard input and validates it test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2 style(interaction): fix styling of the previous commits test(sidenav): add sidenav focus restore test triggered by keyboard test(sidenav): add focus restore test for mouse and patch other one fix(sidenav): test fix(sidenav): replace deprecated methods, and remove aria label test(sidenav): revert deprecated methods.
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 24, 2016
Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 24, 2016
Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 24, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Mar 3, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Apr 7, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Apr 9, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Apr 22, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Aug 26, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Sep 19, 2016
kara
pushed a commit
that referenced
this pull request
Oct 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the Sidenav restores every time the last active element, so the focus won't disappear from the triggered button after closing the sidenav
Fixes #5563