Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

style(eslint): enable keyword-spacing rule #11586

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jan 9, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Our rules allow inconsistent spacing around keywords. We try to enforce this some through code reviews, but it leads to extra work by reviewers and contributors.

Issue Number:
N/A

What is the new behavior?

Enforce consistent spacing and all quick fixing.

This will cause an error: if(myVar){

This will pass linting: if (myVar) {

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added type: chore pr: merge ready This PR is ready for a caretaker to review P4: minor Minor issues. May not be fixed without community contributions. pr: merge safe labels Jan 9, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 9, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 9, 2019
@Splaktar Splaktar force-pushed the lint-keyword-spacing branch from 7b6eb04 to 8adecd9 Compare January 11, 2019 22:57
@Splaktar Splaktar force-pushed the lint-keyword-spacing branch from 8adecd9 to 799de1f Compare January 11, 2019 23:21
@andrewseguin andrewseguin merged commit ecf1705 into master Jan 11, 2019
@Splaktar Splaktar deleted the lint-keyword-spacing branch January 11, 2019 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants