Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

md-ink-ripple wrong y position on absolutely/fixed positioned elements #5508

Closed
@jamesbirtles

Description

@jamesbirtles

The ink starts much further up than it should on absolute and fixed position elements (or descendants of).

If I change line 157 in ripple.js

this.createRipple(event.layerX, event.layerY);

to

this.createRipple(event.offsetX, event.offsetY);

it fixes the position and still works on normal elements.

This is on atom electron v0.34.2 if that helps

Metadata

Metadata

Assignees

Labels

pr: merge readyThis PR is ready for a caretaker to review

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions