Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

feat: add button to copy link to example #922

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

crisbeto
Copy link
Member

Adds the ability to copy an anchor link to a specific example. Has a bit of extra logic to ensure that the browser actually scrolls the element into view.

Fixes angular/components#21884.

@google-cla google-cla bot added the cla: yes label Feb 14, 2021
@crisbeto crisbeto force-pushed the example-link branch 2 times, most recently from a1324d6 to 1a1538a Compare February 14, 2021 09:54
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be super helpful! I've certainly wanted this in the past. I just had some minor comments.

@crisbeto crisbeto force-pushed the example-link branch 3 times, most recently from bd1b58c to edf2101 Compare February 15, 2021 20:39
Adds the ability to copy an anchor link to a specific example. Has a bit of extra logic
to ensure that the browser actually scrolls the element into view.

Fixes angular/components#21884.
@crisbeto
Copy link
Member Author

Feedback has been addressed. Merging.

@crisbeto crisbeto merged commit 591f99f into angular:master Feb 15, 2021
@Totati
Copy link

Totati commented Feb 16, 2021

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples): Anchor for each example
4 participants