Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

bug(plunker): fix plunkers not working with dialogs #5899 #228

Closed
wants to merge 2 commits into from
Closed

bug(plunker): fix plunkers not working with dialogs #5899 #228

wants to merge 2 commits into from

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Jul 23, 2017

@amcdnl amcdnl requested a review from jelbourn July 23, 2017 15:53
@amcdnl amcdnl mentioned this pull request Jul 23, 2017
Closed
@julianobrasil
Copy link

@amcdnl, I haven't seen any mention in the code to the entryComponents array. It should be present in the case of MdDialog.

@jelbourn jelbourn requested a review from tinayuangao July 24, 2017 16:10
@jelbourn
Copy link
Member

@tinayuangao is better to review since she authored the plunker generation

tinayuangao
tinayuangao reviewed Aug 7, 2017
View reviewed changes
src/app/shared/plunker/plunker-writer.ts
// Replace `declarations: [MaterialDocsExample]`
// will be replaced as `declarations: [ButtonDemo]`
fileContent = fileContent.
replace(/declarations: \[MaterialDocsExample\]/g,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also replace entryComponents?

Add entryComponents: [MaterialDocsExample] to main.ts.

I tested on plunker and found out it doesn't work without entryComponents.

@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 9, 2017

@tinayuangao - Is this PR still relevant. Looks like they are working today.

@julianobrasil
Copy link

julianobrasil commented Sep 9, 2017 •
edited
Loading

@amcdnl, @tinayuangao, dialogs are still throwing exceptions (lack of entryComponents).

@amcdnl
Copy link
Contributor Author

amcdnl commented Sep 11, 2017 •
edited
Loading

@julianobrasil where are you seeing it throwing the errors?

@julianobrasil
Copy link

@amcdnl, if you click on the link to the plunk example for the dialogs (at https://material.angular.io/components/dialog/overview), you'll see the errors:

image

Notice that the entryComponents attribute is missing and there are two components in bootstrap attribute.

@julianobrasil julianobrasil mentioned this pull request Oct 29, 2017
Closed
@amcdnl
Copy link
Contributor Author

amcdnl commented Dec 16, 2017

Closing this since it outdated, will update in a new PR.

@amcdnl amcdnl closed this Dec 16, 2017
@amcdnl amcdnl deleted the dialog-plunker-bug branch December 16, 2017 22:31
amcdnl added a commit to amcdnl/material.angular.io that referenced this pull request Dec 16, 2017
@amcdnl
fix(stackblitz): fix dialogs not working #5899 angular#228 #8750
eb53ad7
@amcdnl amcdnl mentioned this pull request Dec 16, 2017
Merged
@amcdnl
Copy link
Contributor Author

amcdnl commented Dec 16, 2017

Resolved here - #356

jelbourn pushed a commit that referenced this pull request Dec 18, 2017
@amcdnl @jelbourn
fix(stackblitz): fix dialogs not working #5899 #228 #8750 (#356)
9c78345
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@tinayuangao tinayuangao

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amcdnl @julianobrasil @jelbourn @tinayuangao @googlebot