Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

build: upgrade to Angular and Material v7 and add strict flags #855

Merged
merged 5 commits into from
Oct 5, 2018
Merged

build: upgrade to Angular and Material v7 and add strict flags #855

merged 5 commits into from
Oct 5, 2018

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Oct 4, 2018 •
edited
Loading

  • Upgrade to Angular v7
  • Upgrade to Angular Material v7
  • Add nostrictPropertyInitialization flag
  • Add noUnusedLocals flag and remove tslint option
  • Add noImplicitThis flag
  • Add noImplicitAny flag
  • Enable strictMetadataEmit flag
  • Various refactors to support the above flags
  • Switch to yarn

Fixes #851

@CaerusKaru
build: upgrade to Angular and Material v7 and add strict flags
a457d91 
* Upgrade to Angular v7
* Upgrade to Angular Material v7
* Add `nostrictPropertyInitialization` flag
* Add `noUnusedLocals` flag and remove tslint option
* Add `noImplicitThis` flag
* Enable `strictMetadataEmit` flag
* Various refactors to support the above flags
@CaerusKaru CaerusKaru added build pr: needs review P1 Urgent issue that should be resolved before the next re-lease labels Oct 4, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.19 milestone Oct 4, 2018
@CaerusKaru CaerusKaru mentioned this pull request Oct 4, 2018
Closed
@CaerusKaru
Copy link
Member Author

Slack LGTM from @ThomasBurleson

@CaerusKaru CaerusKaru added pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: lgtm This PR has been approved by the reviewer and removed pr: needs review labels Oct 5, 2018
@CaerusKaru CaerusKaru merged commit 5234d69 into master Oct 5, 2018
@CaerusKaru CaerusKaru deleted the adam/ng7 branch October 5, 2018 17:46
@CaerusKaru CaerusKaru mentioned this pull request Oct 5, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
build cla: yes P1 Urgent issue that should be resolved before the next re-lease pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge
Projects
None yet
Milestone
v7.0.0-beta.19
Development

Successfully merging this pull request may close these issues.

Cannot compile with typescript 3.1.1
3 participants
@CaerusKaru @ThomasBurleson @googlebot