feat(@ngtools/webpack): return Buffer for file system requests

Author: sis0k0

packages/ngtools/webpack/src/compiler_host.ts

@@ -74,38 +74,77 @@ export class VirtualDirStats extends VirtualStats {
 
 export class VirtualFileStats extends VirtualStats {
   private _sourceFile: ts.SourceFile | null;
-  constructor(_fileName: string, private _content: string) {
+  private _content: string | null;
+  private _bufferContent: virtualFs.FileBuffer | null;
+
+  constructor(_fileName: string) {
     super(_fileName);
   }
 
-  get content() { return this._content; }
+  static createFromString(_fileName: string, _content: string) {
+    const stats = new VirtualFileStats(_fileName);
+    stats.content = _content;
+
+    return stats;
+  }
+
+  static createFromBuffer(_fileName: string, _buffer: virtualFs.FileBuffer) {
+    const stats = new VirtualFileStats(_fileName);
+    stats.bufferContent = _buffer;
+
+    return stats;
+  }
+
+  get content() {
+    if (!this._content && this.bufferContent) {
+      this._content = virtualFs.fileBufferToString(this.bufferContent);
+    }
+
+    return this._content || "";
+  }
   set content(v: string) {
     this._content = v;
-    this._mtime = new Date();
-    this._sourceFile = null;
+    this._bufferContent = null;
+    this.resetMetadata();
+  }
+
+  get bufferContent() {
+    if (!this._bufferContent && this._content) {
+      this._bufferContent = virtualFs.stringToFileBuffer(this._content);
+    }
+
+    return this._bufferContent || virtualFs.stringToFileBuffer("");
   }
+  set bufferContent(buf: virtualFs.FileBuffer) {
+    this._bufferContent = buf;
+    this._content = null;
+    this.resetMetadata();
+  }
+
   setSourceFile(sourceFile: ts.SourceFile) {
     this._sourceFile = sourceFile;
   }
   getSourceFile(languageVersion: ts.ScriptTarget, setParentNodes: boolean) {
     if (!this._sourceFile) {
-      // console.log(this._path)
       this._sourceFile = ts.createSourceFile(
         workaroundResolve(this._path),
-        this._content,
+        this.content,
         languageVersion,
         setParentNodes);
     }
-
     return this._sourceFile;
   }
 
+  private resetMetadata(): void {
+    this._mtime = new Date();
+    this._sourceFile = null;
+  }
+
   isFile() { return true; }
 
-  get size() { return this._content.length; }
+  get size() { return this.content.length; }
 }
 
-
 export class WebpackCompilerHost implements ts.CompilerHost {
   private _syncHost: virtualFs.SyncDelegateHost;
   private _files: {[path: string]: VirtualFileStats | null} = Object.create(null);
@@ -149,8 +188,8 @@ export class WebpackCompilerHost implements ts.CompilerHost {
     }
   }
 
-  private _setFileContent(fileName: Path, content: string) {
-    this._files[fileName] = new VirtualFileStats(fileName, content);
+  private _cacheFile(fileName: string, stats: VirtualFileStats) {
+    this._files[fileName] = stats;
 
     let p = dirname(fileName);
     while (p && !this._directories[p]) {
@@ -211,25 +250,39 @@ export class WebpackCompilerHost implements ts.CompilerHost {
   }
 
   readFile(fileName: string): string | undefined {
+    const stats = this.findVirtualFile(fileName);
+    return stats && stats.content;
+  }
+
+  readFileBuffer(fileName: string): Buffer | undefined {
+    const stats = this.findVirtualFile(fileName);
+    if (stats) {
+      const buffer = Buffer.from(stats.bufferContent);
+      return buffer;
+    }
+  }
+
+  private findVirtualFile(fileName: string): VirtualFileStats | undefined {
     const p = this.resolve(fileName);
 
     const stats = this._files[p];
-    if (!stats) {
-      try {
-        const result = virtualFs.fileBufferToString(this._syncHost.read(p));
-        if (result !== undefined) {
-          if (this._cache) {
-            this._setFileContent(p, result);
-          }
+    if (stats) {
+      return stats;
+    }
+
+    try {
+      const fileBuffer = this._syncHost.read(p);
+      if (fileBuffer) {
+        const stats = VirtualFileStats.createFromBuffer(p, fileBuffer);
+        if (this._cache) {
+          this._cacheFile(p, stats);
         }
 
-        return result;
-      } catch (e) {
-        return undefined;
+        return stats;
       }
+    } catch(e) {
+      return undefined;
     }
-
-    return stats.content;
   }
 
   stat(path: string): VirtualStats | null {
@@ -344,7 +397,8 @@ export class WebpackCompilerHost implements ts.CompilerHost {
       _sourceFiles?: ReadonlyArray<ts.SourceFile>,
     ): void => {
       const p = this.resolve(fileName);
-      this._setFileContent(p, data);
+      const stats = VirtualFileStats.createFromString(p, data);
+      this._cacheFile(p, stats);
     };
   }
 

packages/ngtools/webpack/src/virtual_file_system_decorator.ts

@@ -18,9 +18,9 @@ export class VirtualFileSystemDecorator implements InputFileSystem {
     private _webpackCompilerHost: WebpackCompilerHost,
   ) { }
 
-  private _readFileSync(path: string): string | null {
+  private _readFileSync(path: string): Buffer | null {
     if (this._webpackCompilerHost.fileExists(path)) {
-      return this._webpackCompilerHost.readFile(path) || null;
+      return this._webpackCompilerHost.readFileBuffer(path) || null;
     }
 
     return null;
@@ -51,7 +51,7 @@ export class VirtualFileSystemDecorator implements InputFileSystem {
     this._inputFileSystem.readdir(path, callback);
   }
 
-  readFile(path: string, callback: Callback<string>): void {
+  readFile(path: string, callback: Callback<string | Buffer>): void {
     const result = this._readFileSync(path);
     if (result) {
       callback(null, result);
@@ -78,7 +78,7 @@ export class VirtualFileSystemDecorator implements InputFileSystem {
     return this._inputFileSystem.readdirSync(path);
   }
 
-  readFileSync(path: string): string {
+  readFileSync(path: string): string | Buffer {
     const result = this._readFileSync(path);
 
     return result || this._inputFileSystem.readFileSync(path);

packages/ngtools/webpack/src/webpack.ts

@@ -51,13 +51,13 @@ export interface NormalModuleFactoryRequest {
 export interface InputFileSystem {
   stat(path: string, callback: Callback<Stats>): void;
   readdir(path: string, callback: Callback<string[]>): void;
-  readFile(path: string, callback: Callback<string>): void;
+  readFile(path: string, callback: Callback<string | Buffer>): void;
   // tslint:disable-next-line:no-any
   readJson(path: string, callback: Callback<any>): void;
   readlink(path: string, callback: Callback<string>): void;
   statSync(path: string): Stats;
   readdirSync(path: string): string[];
-  readFileSync(path: string): string;
+  readFileSync(path: string): string | Buffer;
   // tslint:disable-next-line:no-any
   readJsonSync(path: string): any;
   readlinkSync(path: string): string;