Skip to content

chore: add bazel test rules for the cdk #9726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Feb 1, 2018

This adds bazel test rules for everything under cdk/ and sets CircleCI to run them. Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.

@jelbourn jelbourn added pr: needs review area: dev-infra Issue related to internal project infrastructure labels Feb 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 1, 2018
// Monkey-patch the resetTestingModule to destroy fixtures outside of a try/catch block.
// With https://github.com/angular/angular/commit/2c5a67134198a090a24f6671dcdb7b102fea6eba
// errors when destroying components are no longer causing Jasmine to fail.
testBed.resetTestingModule = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are fat-arrows not allowed in this file?

Copy link
Member Author

@jelbourn jelbourn Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was originally a JS file that I copy-pasted. Fixed.

(the one function remaining is necessary since it deals with this)

@jelbourn jelbourn force-pushed the bazel-karma branch 2 times, most recently from b532e8b to 1fc14d5 Compare February 1, 2018 01:01
@jelbourn
Copy link
Member Author

jelbourn commented Feb 1, 2018

I fixed the tests for table/portal. Having NoopAnimationsModule in the set setup causes all view destroying to require a detectChanges (which is somewhat weird and surprising)

@jelbourn
Copy link
Member Author

@mmalerba @alexeagle PTAL

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 12, 2018
This adds bazel test rules for everything under cdk/ and sets CircleCI Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.
@jelbourn jelbourn merged commit 21a83ba into angular:master Feb 13, 2018
@andrewseguin andrewseguin added the target: minor This PR is targeted for the next minor release label Feb 20, 2018
@jelbourn jelbourn mentioned this pull request Feb 21, 2018
17 tasks
@jelbourn jelbourn deleted the bazel-karma branch April 2, 2018 22:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issue related to internal project infrastructure cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants