-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: add bazel test rules for the cdk #9726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// Monkey-patch the resetTestingModule to destroy fixtures outside of a try/catch block. | ||
// With https://github.com/angular/angular/commit/2c5a67134198a090a24f6671dcdb7b102fea6eba | ||
// errors when destroying components are no longer causing Jasmine to fail. | ||
testBed.resetTestingModule = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are fat-arrows not allowed in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was originally a JS file that I copy-pasted. Fixed.
(the one function
remaining is necessary since it deals with this
)
b532e8b
to
1fc14d5
Compare
I fixed the tests for table/portal. Having |
1fc14d5
to
90ec4ce
Compare
@mmalerba @alexeagle PTAL |
This adds bazel test rules for everything under cdk/ and sets CircleCI Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.
90ec4ce
to
94365a0
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This adds bazel test rules for everything under cdk/ and sets CircleCI to run them. Overlay tests don't work because there's not yet a way to pass through flags to the browser. These issues will be addressed in a follow-up PR.