Skip to content

docs(focus): Add docs for regions #8082 #8128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2017
Merged

docs(focus): Add docs for regions #8082 #8128

merged 2 commits into from
Oct 30, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 30, 2017

Addresses #8082

@amcdnl amcdnl self-assigned this Oct 30, 2017
@amcdnl amcdnl requested a review from jelbourn October 30, 2017 15:22
@amcdnl amcdnl requested a review from devversion as a code owner October 30, 2017 15:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
jelbourn
jelbourn reviewed Oct 30, 2017
View reviewed changes
src/cdk/a11y/a11y.md
<a mat-list-item routerLink cdkFocusInitial>Initially focused</a>
<a mat-list-item routerLink cdkFocusRegionEnd>Focus region end</a>
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could be a bit more explicit about what each does:
"cdkFocusInitial specifies the element that will receive focus upon initialization of the region"

"cdkFocusRegionStart and cdkFocusRegionEnd define the region within which focus will be trapped. When using the tab key, focus will move through this region and wrap around on either end."

jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation labels Oct 30, 2017
@mmalerba mmalerba merged commit 804f925 into angular:master Oct 30, 2017
@amcdnl amcdnl deleted the focus-trap-docs-8082 branch October 31, 2017 19:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@amcdnl amcdnl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcdnl @jelbourn @googlebot @mmalerba