Skip to content

demo(tabs): Add accessibility demo page for tabs #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2017
Merged

demo(tabs): Add accessibility demo page for tabs #6610

merged 3 commits into from
Sep 8, 2017

Conversation

tinayuangao
Copy link
Contributor

Closes #6500

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2017
jelbourn
jelbourn approved these changes Aug 23, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Just needs rebase

@tinayuangao tinayuangao added action: merge The PR is ready for merge by the caretaker Accessibility This issue is related to accessibility (a11y) and removed pr: needs rebase labels Aug 28, 2017
@tinayuangao tinayuangao force-pushed the a11y-tab branch 2 times, most recently from 0ea9075 to 2ae28be Compare August 29, 2017 20:28
@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Sep 1, 2017
@jelbourn
Copy link
Member

jelbourn commented Sep 1, 2017

@tinayuangao this is failing the aot task

@tinayuangao tinayuangao added the action: merge The PR is ready for merge by the caretaker label Sep 7, 2017
@tinayuangao tinayuangao merged commit f2cae6e into angular:master Sep 8, 2017
@tinayuangao tinayuangao deleted the a11y-tab branch March 9, 2018 23:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@amcdnl amcdnl Awaiting requested review from amcdnl

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create accessibility demo page for Tabs
3 participants
@tinayuangao @jelbourn @googlebot