demo(card): Add accessibility demo page for card #6358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
changed the title
tinayuangao
added
Accessibility
tinayuangao
force-pushed
the
a11y-card
branch
3 times, most recently
from
b274185 to
fad7589
Compare
jelbourn
reviewed
Aug 16, 2017
| <section> | ||
| <h2>Husky</h2> | ||
| <p>Showing a card with title only</p> | ||
| <md-card class="example-card"> |
There was a problem hiding this comment.
Should any of these <md-card> instances have role="group"?
(to line up with the docs https://material.angular.io/components/card/overview)
There was a problem hiding this comment.
Added another example with role="group"
| <p>Showing a card with title, subtitle, and avatar as header and a card image.</p> | ||
| <md-card class="example-card"> | ||
| <md-card-header> | ||
| <img md-card-avatar src="a11y/card/assets/dachshund-avatar.jpg" aria-label="Dachshund avatar"> |
| language. The breed is also known as the Alsatian in Britain and Ireland. | ||
| </md-card-content> | ||
| <md-card-actions> | ||
| Search for more dogs... |
There was a problem hiding this comment.
Will this be weird since there's not a real search?
|
Added another example for |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.