Skip to content

chore: remove duplicated key managers #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2017
Merged

chore: remove duplicated key managers #6332

merged 2 commits into from
Aug 16, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2017

Removes the FocusKeyManager class that was duplicated from the CDK.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2017
@crisbeto crisbeto changed the title chore: remove duplicated FocusKeyManager chore: remove duplicated key managers Aug 7, 2017
jelbourn
jelbourn approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 7, 2017
@crisbeto crisbeto force-pushed the focus-key-manager-dupe branch from c6514d4 to e689e05 Compare August 9, 2017 17:18
@andrewseguin
Copy link
Contributor

Please rebase

@crisbeto crisbeto force-pushed the focus-key-manager-dupe branch from e689e05 to 7af6966 Compare August 14, 2017 05:36
@andrewseguin
Copy link
Contributor

Needs rebase

@kara kara removed their request for review August 16, 2017 00:40
@crisbeto
chore: remove duplicated FocusKeyManager
75f12fc 
Removes the FocusKeyManager class that was duplicated from the CDK.
@crisbeto
chore: also remove duplicate activedescendant
52aead3
@crisbeto crisbeto force-pushed the focus-key-manager-dupe branch from 7af6966 to 52aead3 Compare August 16, 2017 17:42
@andrewseguin andrewseguin merged commit 6b93572 into angular:master Aug 16, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @andrewseguin @jelbourn @googlebot