chore(dialog): switch to OnPush change detection #6126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
added
the
presubmit failures
jelbourn
added
pr: lgtm
action: merge
|
Setting to merge-ready so it shows up on caretaker's radar |
crisbeto
force-pushed
the
5035/dialog-onpush
branch
from
da730df to
0850981
Compare
|
@jelbourn for some reason rebasing this one ended up clearing all the changes, probably because of the revert commit on the previous PR. I'll re-re-open it with a brand new commit. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the dialog container to
OnPushchange detection.Relates to #5035.
Note: This is the same changeset from #5422 so we can continue investigating the sync failures.