Skip to content

docs(table): add missing imports and improve example using http #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 28, 2017
Merged

docs(table): add missing imports and improve example using http #5956

merged 7 commits into from
Jul 28, 2017

Conversation

rafaelss95
Copy link
Contributor

@rafaelss95 rafaelss95 commented Jul 21, 2017 •
edited
Loading

  • Add missing OnInit import.
  • Remove unused operator imports.
  • Remove unnecessary type annotations.
  • Create a simple interface called GithubApi to transform the request.

DEMO

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2017
@rafaelss95
Copy link
Contributor Author

@andrewseguin can you review this?

@rafaelss95 rafaelss95 changed the title refactor: add missing imports and improve table-http-example docs(table): add missing imports and improve example using http Jul 22, 2017
andrewseguin
andrewseguin approved these changes Jul 22, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small change

src/material-examples/table-http/table-http-example.ts Outdated
.switchMap(() => {
this.isLoadingResults = true;
return this.exampleDatabase.getRepoIssues(
this.sort.active, this.sort.direction, this.paginator.pageIndex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bring up the );, doesn't fit the rest of the style in the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguin can you merge this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelss95 Needs a rebase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguin done.

@lemang
Copy link

lemang commented Jul 23, 2017

can you add example for filter?

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 27, 2017
@andrewseguin andrewseguin merged commit aea8df4 into angular:master Jul 28, 2017
@rafaelss95 rafaelss95 deleted the fix-example branch July 29, 2017 18:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafaelss95 @lemang @andrewseguin @googlebot