build: fix screenshot functions deploying #5780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Jul 15, 2017
devversion
commented
- Fixes the screenshot functions deploying by properly resolving the path to the Firebase CLI binary.
- Also cleans up the script to be aligned with the dashboard deployment script.
- Removes firebase-tools as dependency from the dashboard since it's not used there anymore
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@devversion needs rebase now |
* Fixes the screenshot functions deploying by properly resolving the path to the Firebase CLI binary. * Also cleans up the script to be aligned with the dashboard deployment script. * Removes firebase-tools as dependency from the dashboard since it's not used there anymore
devversion
force-pushed
the
build/fix-screenshot-functions-deployment
branch
from
9a24db9 to
266ef80
Compare
|
@jelbourn Done. |
1 similar comment
|
@jelbourn Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.