Skip to content

build: switch to npm package-lock file #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2017

Conversation

devversion
Copy link
Member

  • No longer tracks the yarn.lock file and switches to NPM's package-lock file (for NPM v5)

@jelbourn The CI currently doesn't use NPM v5 yet, but there may happen some updates from Travis CI in the upcoming days. If necessary we can just install NPM v5 manually as well.

* No longer tracks the yarn.lock file and switches to NPM's `package-lock` file (for NPM v5)
@devversion devversion requested a review from jelbourn May 31, 2017 17:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 31, 2017
@crisbeto
Copy link
Member

FWIW, switching to Node 8 should include NPM 5 as well.

@devversion
Copy link
Member Author

@crisbeto Yeah considered that too but Node 8 is not a LTS version yet.

And for now we should run our tooling with the LTS version (ensuring that most of the people can use our tooling)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 31, 2017
@mmalerba mmalerba merged commit 945aa43 into angular:master May 31, 2017
@devversion devversion deleted the build/switch-to-npm-lock branch June 2, 2017 16:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants