build: minify html before inlining resources #4877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
May 30, 2017
| @@ -26,7 +27,10 @@ export function createPackageBuildTasks(packageName: string, requiredPackages: s | |||
| const esmMainFile = join(packageOut, 'index.js'); | |||
|
|
|||
| // Glob that matches all assets that should be copied to the package. | |||
| const assetsGlob = join(packageRoot, '**/*.+(html|scss|css)'); | |||
| const assetsGlob = join(packageRoot, '**/*.+(scss|css)'); | |||
There was a problem hiding this comment.
Since this doesn't include HTML anymore, it can just be stylesGlob
* Now minifies the HTML files before inlining the resources. This drops unnecessary whitespace due to previous line breaks and developers can easily test with Material components. Fixes angular#1596
devversion
force-pushed
the
build/release-output-whitespace
branch
from
75dbaf9 to
5aa32e1
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The minifying could be done in another utility file as well but all our utility files should be done without gulp (because we want to have a standalone packaging tool). Only the
build-tasks-gulpshould contain gulp-related stuff.Fixes #1596