build: serve e2e-app in aot mode #4833
Conversation
googlebot
added
the
cla: yes
src/e2e-app/main-aot.ts
Outdated
| import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; | ||
| import {E2eAppModuleNgFactory} from './e2e-app-module.ngfactory'; | ||
|
|
||
| platformBrowserDynamic().bootstrapModuleFactory(E2eAppModuleNgFactory); |
There was a problem hiding this comment.
Shouldn't this just be platformBrowser (without the Dynamic)?
(same for demo-app, now that I notice it)
There was a problem hiding this comment.
Yeah I think @josephperrott also had an issue about it but I didn't assign it to myself so I lost track of it. Changed it now.
src/e2e-app/main-aot.ts
Outdated
| @@ -0,0 +1,4 @@ | |||
| import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; | |||
There was a problem hiding this comment.
Instead of having a separate main-aot.ts, we should just make this the main main.ts; nobody should need to ever run this in JIT mode
jelbourn
added
pr: lgtm
action: merge
|
please rebase |
mmalerba
added
pr: needs rebase
and removed
action: merge
* Starts building the e2e-app in AOT mode
devversion
force-pushed
the
build/e2e-app-aot
branch
from
ed203fe to
3aeace2
Compare
devversion
force-pushed
the
build/e2e-app-aot
branch
from
3aeace2 to
0c1c166
Compare
devversion
added
action: merge
|
@mmalerba Done. This also includes the fix for the CI failure.
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Starts building the e2e-app in AOT mode
This should make our e2e tests on the CI faster and also should be a more advanced testing of AOT compatibility.
Note: As this also makes the e2e-app smaller in payload I will try to find a way to use a RxJS bundle (would speed-up the serving a lot)