build: remove whitespace at eof and between tags #4392
Conversation
googlebot
added
the
cla: yes
| @@ -93,7 +93,9 @@ function inlineTemplate(content, urlResolver) { | |||
| const templateContent = fs.readFileSync(templateFile, 'utf-8'); | |||
| const shortenedTemplate = templateContent | |||
| .replace(/([\n\r]\s*)+/gm, ' ') | |||
There was a problem hiding this comment.
This seems to be a overkill fix. Why not just remove the space here and just replace it with an empty string?
There was a problem hiding this comment.
Wouldn't that remove the spaces between attributes too aggressively? Such as after <ng-content:
<ng-content select="[md-card-avatar], [mat-card-avatar]"></ng-content>
<div class="mat-card-header-text">
<ng-content
select="md-card-title, mat-card-title, md-card-subtitle, mat-card-subtitle,
[md-card-title], [mat-card-title], [md-card-subtitle], [mat-card-subtitle]"></ng-content>
</div>
<ng-content></ng-content>There was a problem hiding this comment.
That's a good point. Couldn't we just use gulp-clean-css to do proper minifying?
There was a problem hiding this comment.
Yeah, sure. I considered reusing htmlmin, but that seemed like overkill to me haha. I'll close this if you'd prefer to take on a different approach.
There was a problem hiding this comment.
You can just do it in that PR and you don't have to close the PR.
|
Not sure what the status of this PR is now- I'm just going to close it and you can open a new one if you want to go for a different approach. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #1596