Skip to content

chore: added @angular/forms as peer dependency #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: added @angular/forms as peer dependency #4331

wants to merge 1 commit into from

Conversation

csvn
Copy link
Contributor

@csvn csvn commented Apr 29, 2017

I just created a blank app with @angular/[email protected], and removed forms dependency (since I was not planning to use any forms). When serving up the app and adding @angular/material I got this error:

image

Seems to me that @angular/forms should be a peer dependency if material be imported without errors with no forms module.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2017
@crisbeto
Copy link
Member

@angular/forms will soon become an optional dependency. See #3792.

@csvn
Copy link
Contributor Author

csvn commented Apr 29, 2017

@crisbeto I had no idea, I did not find anything related. Feel free to close this PR then 🙂

@crisbeto crisbeto closed this Apr 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants