Skip to content

demo(slide-toggle): change outdated switch selector #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

devversion
Copy link
Member

At some point the slide-toggle has been called switch.

The selector inside of the demo-app is still using switch instead of slide-toggle.

Noticed this while debugging the slide-toggle with Augury.

* At some point the `slide-toggle` has been called `switch`. The
selector inside of the demo-app is still using `switch` instead of
`slide-toggle`.
@devversion devversion requested a review from jelbourn April 18, 2017 16:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 18, 2017
@jelbourn jelbourn merged commit e73af7d into angular:master Apr 18, 2017
@devversion devversion deleted the update/selector-demo-app branch April 18, 2017 16:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants