Skip to content

style(progress): don't use hardcoded hues #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2017

Conversation

willshowell
Copy link
Contributor

The progress bars and progress spinners were defaulting to the 600 and 100 hues. This will use the default hue and the lighter hue, respectively.

Fixes #3935

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 13, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 13, 2017
@kara kara added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 21, 2017
@mmalerba
Copy link
Contributor

Seeing this error: Error: argument `$color` of `opacity($color)` must be a color

       Backtrace:
       	src/lib/core/theming/_theming.scss:55, in function `opacity`
       	src/lib/core/theming/_theming.scss:55, in function `if`
       	src/lib/core/theming/_theming.scss:55, in function `mat-color`
       	src/lib/progress-bar/_progress-bar-theme.scss:61, in function `_mat-progress-bar-buffer`
       	src/lib/progress-bar/_progress-bar-theme.scss:37, in mixin `mat-progress-bar-theme`
       	src/lib/core/theming/_all-theme.scss:42, in mixin `angular-material-theme`
        on line 55 of src/lib/core/theming/_theming.scss
>>   $opacity: if($opacity == null, opacity($color), $opacity);
   ---------------------------------^

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Apr 28, 2017
@willshowell
Copy link
Contributor Author

@mmalerba Weird, the only way I'm able to replicate that error is by changing line 37 of _progress-bar-theme like this:

-background: #{_mat-progress-bar-buffer($warn, lighter)};
+background: #{_mat-progress-bar-buffer($warn, invalid-val)};

Do you have any more information/suggestions?

@mmalerba
Copy link
Contributor

Ah ok, I looked into it a bit further and it looks like the project with the failures is constructing a theme with invalid palettes. I'll add back merge-ready since there's nothing to do here, we'll just have to work with that team to correct it.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2017
@andrewseguin andrewseguin merged commit 2481ee3 into angular:master May 2, 2017
@willshowell willshowell deleted the style-progress-hues branch May 24, 2017 15:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme color hue values for MdProgressSpinner, MdProgressBar are hardcoded
6 participants