Skip to content

guide(theming): update custom theme section #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fxck
Copy link
Contributor

@fxck fxck commented Apr 10, 2017

reasoning in this issue #1786

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 10, 2017
@willshowell
Copy link
Contributor

@fxck @jelbourn I strongly agree with this change. I lost more time than I'd like to admit tracking down why my bundles kept increasing in size, only to realize the theming guide was a slightly misleading.

@jelbourn
Copy link
Member

I've opened #4021 to try to address both this and a couple of other common issues. Let me know what you think.

@fxck fxck closed this Apr 11, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants