Skip to content

build: switch to new protractor rule #30847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

devversion
Copy link
Member

Switches to our new simplified Protractor rule, that isn't based on rules_js and uses our latest browser Chrome headless shell version, based on Puppeteer.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 10, 2025
@devversion devversion force-pushed the switch-to-new-protractor-rule branch from 5562f17 to 25dc280 Compare April 10, 2025 18:55
@devversion devversion marked this pull request as ready for review April 10, 2025 19:01
@devversion devversion requested review from a team as code owners April 10, 2025 19:01
@devversion devversion requested review from mmalerba and andrewseguin and removed request for a team April 10, 2025 19:01
Switches to our new simplified Protractor rule, that isn't based on
`rules_js` and uses our latest browser Chrome headless shell version,
based on Puppeteer.
@devversion devversion force-pushed the switch-to-new-protractor-rule branch from 25dc280 to 81f7e12 Compare April 10, 2025 19:16
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🎉

@devversion devversion added the target: patch This PR is targeted for the next patch release label Apr 11, 2025
@devversion devversion removed the request for review from mmalerba April 11, 2025 06:38
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 11, 2025
@devversion devversion merged commit dac7bc8 into angular:main Apr 11, 2025
24 of 26 checks passed
@devversion
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

devversion added a commit that referenced this pull request Apr 11, 2025
Switches to our new simplified Protractor rule, that isn't based on
`rules_js` and uses our latest browser Chrome headless shell version,
based on Puppeteer.

(cherry picked from commit dac7bc8)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants