feat(material/button): allow appearance to be set dynamically #30626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: major
angular-robot
bot
added
detected: breaking change
crisbeto
force-pushed
the
15367/dynamic-button-type
branch
from
a8f588e to
c6cb080
Compare
Adds the following features to the button: * Allows the appearance of a button to be set dynamically using the `matButton` input. * Aligns the terminology with the M3 spec. Currently the names are derived from an old spec. * Adds the ability to set the default appearance for buttons. * Adds a `matIconButton` selector to the icon button for consistency. * Adds a `matFab` selector to the FAB for consistency. * Adds a `matMiniFab` selector to the mini FAB for consistency. All of these changes are backwards-compatible and allow us to evolve the button in the future. Fixes angular#15367. Fixes angular#29841.
crisbeto
force-pushed
the
15367/dynamic-button-type
branch
3 times, most recently
from
bacfd17 to
cea2075
Compare
Updates the button harness to align with the terminology for button appearances. BREAKING CHANGE: * `ButtonVariant` which is returned by `MatButtonHarness.getVariant` no longer includes the appearance of the button. Use `MatButtonHarness.getAppearance` instead.
Reworks the various places where we have buttons to use the new selectors.
crisbeto
force-pushed
the
15367/dynamic-button-type
branch
from
cea2075 to
2347d69
Compare
andrewseguin
approved these changes
Mar 13, 2025
| const inferredAppearance = _inferAppearance(element); | ||
|
|
||
| // This class is common across all the appearances so we add it ahead of time. | ||
| element.classList.add('mdc-button'); |
There was a problem hiding this comment.
would be easier to just make this a host binding?
There was a problem hiding this comment.
I was trying to match the behavior of what we do at the moment. Moving it into a host binding can change the order in which the class is applied which can break internal clients and I was trying to minimize the amount of breakages. I can try moving it in a follow-up. We'll have to shuffle around the host object a bit anyways if we want to get type checking support for it.
There was a problem hiding this comment.
Ah okay that makes sense
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 14, 2025
Following up on angular#30626 (comment), these changes move the button's shared host bindings into the base class and turn some classes that are added manually into host bindings. The previous approach was only necessary with ViewEngine, because it wasn't doing inheritance of host bindings correctly and wasn't merging classes. These are no longer issues in Ivy.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 14, 2025
Following up on angular#30626 (comment), these changes move the button's shared host bindings into the base class and turn some classes that are added manually into host bindings. The previous approach was only necessary with ViewEngine, because it wasn't doing inheritance of host bindings correctly and wasn't merging classes. These are no longer issues in Ivy. Finally, these changes allow us to take advantage of an upcoming framework feature: angular/angular#60267
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 14, 2025
Following up on angular#30626 (comment), these changes move the button's shared host bindings into the base class and turn some classes that are added manually into host bindings. The previous approach was only necessary with ViewEngine, because it wasn't doing inheritance of host bindings correctly and wasn't merging classes. These are no longer issues in Ivy. Finally, these changes allow us to take advantage of an upcoming framework feature: angular/angular#60267
crisbeto
added a commit
that referenced
this pull request
Mar 17, 2025
Following up on #30626 (comment), these changes move the button's shared host bindings into the base class and turn some classes that are added manually into host bindings. The previous approach was only necessary with ViewEngine, because it wasn't doing inheritance of host bindings correctly and wasn't merging classes. These are no longer issues in Ivy. Finally, these changes allow us to take advantage of an upcoming framework feature: angular/angular#60267
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following features to the button:
matButtoninput.matIconButtonselector to the icon button for consistency.matFabselector to the FAB for consistency.matMiniFabselector to the mini FAB for consistency.All of these changes are backwards-compatible and allow us to evolve the button in the future.
BREAKING CHANGE:
ButtonVariantwhich is returned byMatButtonHarness.getVariantno longer includes the appearance of the button. UseMatButtonHarness.getAppearanceinstead.Fixes #15367.
Fixes #29841.