-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(): add interaction service for a11y #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c967286
to
e4a58f1
Compare
e4a58f1
to
b983bc4
Compare
We're working on a fastclick solution in core that should make some of this easier (handling touch delay, possibly new APIs for global event listeners, etc). It would probably make sense to wait on this functionality a bit and re-visit after. cc @jelbourn |
@kara I'm fine with that - this PR can wait for the fastclick solution, but it should be also able to land, because once the Fastclick Solution is landed, we just need to remove the buffer, which is really small effort. |
@devversion I chatted with @kara about this and we agreed that it would be better to wait for the fastclick to land because it will make this service simpler. |
@jelbourn Okay cool, just come back if fastclick is available and I will rebase on top of that ;) |
@marcysutton do you have any thoughts about the combination "progressbar" / "button" from any a11y standpoint? I would guess that you'd want the two to be siblings in the DOM rather than one inside of the other. I'd also think that you'd want the "progressbar" to be aria-hidden until the button interaction, meaning you might want it to seem like the progress bar is "inserted" after the button is clicked. Not sure if it would make any sense whatsoever to manipulate focus during this interaction. |
Just realized my previous comment was on the wrong issue. It should have been on #290 |
@devversion, we're going to try to approach this instead by adding a feature to Zones that can tell you the type of the most recent event was, and then only show if it was a |
I'll be very curious to see what that feature looks like. Differentiating between keydown and click can get tricky depending on the element's role. |
@jelbourn Sounds interesting. Also wouldn't that mean that the events have to be triggered inside of a zone? |
@devversion not sure, depends on how @robertmesserle implements it. @marcysutton I can CC you on the PR once it exists (and if we validate that the idea works in general). |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #289.