Skip to content

fix(material/select): avoid error if panel is closed too quickly #30408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

crisbeto
Copy link
Member

Fixes a regression after #30363 where the select panel throws an error if open and close are called before Angular has had a chance to resolve the panel.

Fixes a regression after angular#30363 where the select panel throws an error if `open` and `close` are called before Angular has had a chance to resolve the `panel`.
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Jan 28, 2025
@crisbeto crisbeto requested a review from a team as a code owner January 28, 2025 20:24
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team January 28, 2025 20:24
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from mmalerba January 28, 2025 20:37
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2025
@crisbeto crisbeto merged commit 86ad515 into angular:main Jan 28, 2025
23 of 25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/select target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants