Skip to content

fix(cdk/menu): not responding to position changes #30234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/cdk/menu/menu-trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ import {
ElementRef,
inject,
NgZone,
OnChanges,
OnDestroy,
Renderer2,
SimpleChanges,
} from '@angular/core';
import {InputModalityDetector} from '@angular/cdk/a11y';
import {Directionality} from '@angular/cdk/bidi';
Expand Down Expand Up @@ -72,7 +74,7 @@ import {eventDispatchesNativeClick} from './event-detection';
PARENT_OR_NEW_MENU_STACK_PROVIDER,
],
})
export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnDestroy {
export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnChanges, OnDestroy {
private readonly _elementRef: ElementRef<HTMLElement> = inject(ElementRef);
private readonly _overlay = inject(Overlay);
private readonly _ngZone = inject(NgZone);
Expand Down Expand Up @@ -133,6 +135,12 @@ export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnDestroy {
return this.childMenu;
}

ngOnChanges(changes: SimpleChanges) {
if (changes['menuPosition'] && this.overlayRef) {
this.overlayRef.updatePositionStrategy(this._getOverlayPositionStrategy());
}
}

override ngOnDestroy(): void {
this._cleanupMouseenter();
super.ngOnDestroy();
Expand Down
6 changes: 5 additions & 1 deletion tools/public_api_guard/cdk/menu.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ import { InjectionToken } from '@angular/core';
import { Injector } from '@angular/core';
import { NgZone } from '@angular/core';
import { Observable } from 'rxjs';
import { OnChanges } from '@angular/core';
import { OnDestroy } from '@angular/core';
import { Optional } from '@angular/core';
import { OverlayRef } from '@angular/cdk/overlay';
import { QueryList } from '@angular/core';
import { Renderer2 } from '@angular/core';
import { ScrollStrategy } from '@angular/cdk/overlay';
import { SimpleChanges } from '@angular/core';
import { Subject } from 'rxjs';
import { TemplatePortal } from '@angular/cdk/portal';
import { TemplateRef } from '@angular/core';
Expand Down Expand Up @@ -202,12 +204,14 @@ export class CdkMenuModule {
}

// @public
export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnDestroy {
export class CdkMenuTrigger extends CdkMenuTriggerBase implements OnChanges, OnDestroy {
constructor();
close(): void;
getMenu(): Menu | undefined;
_handleClick(): void;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
// (undocumented)
ngOnDestroy(): void;
open(): void;
_setHasFocus(hasFocus: boolean): void;
Expand Down
Loading