build: use typescript cli for compilation #2802
Conversation
* No longer use the `gulp-typescript` gulp package that tries to take care of several options like `sourceMaps` or `declarations`. * Don't generate declarations when serving the `demo-app`. (Slows down testing) Advantages: * Use the `Typescript` compiler CLI to ensure that the `NGC` also works with our `tsconfig.json` files. * No longer makes our TypeScript build dependent to an external plugin (~with magic) * Fixes issues like invalid sourceMaps from `gulp-typescript`: angular#2753 * Allows us to take use of all TypeScript features (e.g forbidden features in `gulp-typescript) * This should help for our planned `tsconfig.json` file reduction.
googlebot
added
the
cla: yes
| "./demo-app-types.d.ts", | ||
| "./demo-app-module.ts", | ||
| "./system-config.ts", | ||
| "./main.ts" |
There was a problem hiding this comment.
In the past WebStorm had issues when you specified files where it would only provide completion / error checking for exactly these files and not their dependencies. Are you able to tell if that's still an issue?
There was a problem hiding this comment.
Just looked at it. The issue you described has been solved in Webstorm.
I just noticed that if you create a file (that is never referenced) Webstorm will complain for example about experimentalDecorator support. I don't consider this is as a big issue. What are your thoughts?
There was a problem hiding this comment.
That's probably okay- we shouldn't have any dead code anyway.
There was a problem hiding this comment.
Yeah, also I think that it's not very typically for TS to not use a glob to walk through the files, instead TS walks through the chain of files.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
gulp-typescriptgulp package that tries to take care of several options likesourceMapsordeclarations.demo-app. (Slows down testing)Advantages:
Typescriptcompiler CLI to ensure that theNGCalso works with ourtsconfig.jsonfiles.gulp-typescript: build: fix sourcemaps for dev-app and e2e-app. #2753sourceMapsoption)tsconfig.jsonfile reduction.