refactor: avoid polluting the user's rxjs setup #2652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
arciisine
reviewed
Jan 14, 2017
CODING_STANDARDS.md
Outdated
| someObservable.map(...).subscribe(...); | ||
|
|
||
| // YES | ||
| import {map} from 'rxks/operator/map'; |
crisbeto
force-pushed
the
observable-clusterfuck
branch
from
f1ebe26 to
5af94df
Compare
Currently, the internal uses of RxJS operators are done via patch imports, which add methods directly to the global `Observable` object. This can be an issue since the user may not know where these methods are coming from and may depend on them. Afterwards, if Material removes a method import, the user's app will break since the methods won't be defined anymore. This PR: * Replaces all of the patch imports with imports of individual operators and fixes any issues that showed up afterwards. * Adds a `FunctionChain` class to help with chaining the individually-imported operators. Fixes angular#2622.
crisbeto
force-pushed
the
observable-clusterfuck
branch
from
5af94df to
21ee585
Compare
# Conflicts: # src/lib/autocomplete/autocomplete-trigger.ts # src/lib/dialog/dialog-container.ts
|
This is still something we need to do, but it's going to get stuck rebasing all the time if we're not ready for it. @crisbeto let's give this another try after beta.3 and ng-conf We should also introduce a lint check at the same time so that we don't keep adding more in the future. |
jelbourn
added
the
blocked
|
Is this still scheduled for beta 4, or do you expect it will be bumped? |
|
We may push it out a bit- we're waiting to see if rxjs will add a more convenient syntax |
|
Closing in favor of #5314. |
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the internal uses of RxJS operators are done via patch imports, which add methods directly to the global
Observableobject. This can be an issue since the user may not know where these methods are coming from and may depend on them. Afterwards, if Material removes a method import, the user's app will break since the methods won't be defined anymore. This PR:FunctionChainclass to help with chaining the individually-imported operators.Fixes #2622.