Skip to content

docs: add note about mat-app-background to theming guide #24125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

docs: add note about mat-app-background to theming guide #24125

merged 1 commit into from
Feb 18, 2022

Conversation

crisbeto
Copy link
Member

We used to have this note in the old theming guide, but it looks like it was lost in-between the rewrites.

Fixes #24090.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Dec 21, 2021
@crisbeto crisbeto requested a review from jelbourn as a code owner December 21, 2021 06:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
jelbourn
jelbourn reviewed Jan 7, 2022
View reviewed changes
@crisbeto
docs: add note about mat-app-background to theming guide
33bc0ee 
We used to have this note in the old theming guide, but it looks like it was lost in-between the rewrites.

Fixes angular#24090.
@crisbeto crisbeto force-pushed the 24090/theming-guide-app-background branch from e86e048 to 33bc0ee Compare January 8, 2022 05:41
@crisbeto
Copy link
Member Author

crisbeto commented Jan 8, 2022

The feedback has been addressed.

jelbourn
jelbourn approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 15, 2022
@andrewseguin andrewseguin merged commit 341d14b into angular:master Feb 18, 2022
andrewseguin pushed a commit that referenced this pull request Feb 18, 2022
@crisbeto @andrewseguin
docs: add note about mat-app-background to theming guide (#24125)
3ffcd2e 
We used to have this note in the old theming guide, but it looks like it was lost in-between the rewrites.

Fixes #24090.

(cherry picked from commit 341d14b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(dark-mode-guide): Documentation incomplete since version 11.2.12
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin