Skip to content

feat(material/sort): default arrow position in MatSortDefaultOptions #23609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

feat(material/sort): default arrow position in MatSortDefaultOptions #23609

merged 1 commit into from
Feb 18, 2022

Conversation

lekhmanrus
Copy link
Contributor

closes #23600

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2021
@lekhmanrus lekhmanrus force-pushed the sort-default-arrow-position branch from e417089 to 6cfade9 Compare September 20, 2021 23:57
@lekhmanrus lekhmanrus requested a review from a team as a code owner September 20, 2021 23:57
@lekhmanrus lekhmanrus force-pushed the sort-default-arrow-position branch from 6cfade9 to b603f10 Compare September 21, 2021 00:05
@lekhmanrus lekhmanrus changed the title feat(sort): default arrow position in MatSortDefaultOptions feat(material/sort): default arrow position in MatSortDefaultOptions Sep 21, 2021
crisbeto
crisbeto reviewed Sep 21, 2021
View reviewed changes
@lekhmanrus lekhmanrus force-pushed the sort-default-arrow-position branch 2 times, most recently from b3b48a9 to a4e72e1 Compare September 21, 2021 16:54
@josephperrott josephperrott removed the request for review from a team November 5, 2021 16:04
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@lekhmanrus lekhmanrus force-pushed the sort-default-arrow-position branch from a4e72e1 to b93f006 Compare February 4, 2022 23:58
@lekhmanrus lekhmanrus requested a review from crisbeto February 5, 2022 00:17
@lekhmanrus lekhmanrus force-pushed the sort-default-arrow-position branch from b93f006 to 10963a4 Compare February 18, 2022 00:18
crisbeto
crisbeto approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release and removed needs rebase labels Feb 18, 2022
@andrewseguin andrewseguin merged commit 0d162a4 into angular:master Feb 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Ability to set default arrow position in MatSortDefaultOptions
4 participants
@lekhmanrus @crisbeto @googlebot @andrewseguin