refactor: convert dash-case md-autosize to camelCase #2339
Conversation
googlebot
added
the
cla: yes
|
LGTM, thanks |
jelbourn
added
pr: lgtm
action: merge
|
@EladBezalel I also just realized that the properties should also be renamed to |
EladBezalel
force-pushed
the
refactor/mdAutosize
branch
3 times, most recently
from
a353dec to
3db684a
Compare
|
Yeah, that would be good; we'd still need to support the old names for one release as well (via getter / setter) |
EladBezalel
force-pushed
the
refactor/mdAutosize
branch
2 times, most recently
from
f253d2c to
c7d9792
Compare
…sizeMaxRows - left minRows and maxRows to not break old versions
EladBezalel
force-pushed
the
refactor/mdAutosize
branch
from
c7d9792 to
32fef12
Compare
|
updated, @jelbourn please review |
| return this.minRows; | ||
| } | ||
|
|
||
| @Input() set mdAutosizeMinRows(value: number) { |
There was a problem hiding this comment.
@Input() should go on the getter. We should add that to the coding standards...
| return this.maxRows; | ||
| } | ||
|
|
||
| @Input() set mdAutosizeMaxRows(value: number) { |
There was a problem hiding this comment.
The unit test needs to be updated as well.
There was a problem hiding this comment.
do you mean adding another part that checks that the old and the new api works?
There was a problem hiding this comment.
The test component in the spec still has minRows and maxRows. It should use the updated API.
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.