Skip to content

docs: add remaining component overviews #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 22, 2016

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 22, 2016
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor typos/nitpicks.

@@ -1,4 +1,4 @@
Cards are content containers for text, photos, and actions. Cards are intended to provide
`<md-cards>` is a content container for text, photos, and actions. Cards are intended to provide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<md-cards> -> <md-card>

# md-grid-list

`md-grid-list` is an alternative list view that arranges cells into grid-based layout.
`md-grid-list` is an two-dimensional list view that arranges cells into grid-based layout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an two-dimensional" -> "a two-dimensional"

### `input` and `textarea` attributes

All of the attributes that can be used with normal `input` and `textarea` elements can be used on
elements within the `md-input-container` as well. This includes angular specific ones such as
elements inside `md-input-container` as well. This includes angular specific ones such as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Angular should be capitalized?


### Dense lists
Lists are also available in "dense layout" mode, which shrinks the font size and height of the list
to suit UIs that may need to display more information. To enable this mode, add a `dense` attribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a double space before the "To enable".

```

### Toggling the menu programmatically
The menu exposes an API to open/close programmatically. Please note that in this case, an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an mdMenuTriggerFor directive" -> "a mdMenuTriggerFor directive"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an is right when the following word starts with the "em" sound.

@@ -0,0 +1,29 @@
`<md-checkbox>` provides the same functionality as a native `<input type="radio">` enhanced with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be <md-radio-button>? There's another instance a little bit below.

@@ -0,0 +1,8 @@
`<md-select>` is a form control for selecting a value from a set of options., similar to the native
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's both a stop and a comma after "options".



### Positioning the sidenav
The `align` propert determines whether the sidenav appears at the `"start"` or `"end"` of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a "y" on "propert".

@@ -0,0 +1,22 @@
`<md-slide-toggle>` is an on/off control that can be toggled via clicking or dragging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need some kind of indication for the components that need HammerJS?

let snackBarRef = snackbar.openFromComponent(MessageArchivedComponent);
```

In either case, an `MdSnackBarRef` is returned. This can be used to dismiss the snack-bar or to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an MdSnackBarRef -> a MdSnackBarRef

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@jelbourn
Copy link
Member Author

Addressed comments. Mentioned hammer on the relevant components.

@jelbourn jelbourn closed this Dec 22, 2016
@jelbourn jelbourn reopened this Dec 22, 2016
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit ed5479c into angular:master Dec 22, 2016
@zerox577
Copy link

the grid list not is responsive?

@dahaupt
Copy link

dahaupt commented Dec 28, 2016

@zerox577 You can use https://github.com/angular/flex-layout to create responsive behavior. :)

@zerox577
Copy link

zerox577 commented Dec 28, 2016 via email

@dahaupt
Copy link

dahaupt commented Dec 28, 2016

@zerox577 Exactly, it's an Angular 2 component layout engine. I am using it as well in my projects.

@jelbourn jelbourn deleted the final-overviews branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants